sky/engine/core/html/parser/HTMLScriptRunner.cpp - Issue 688033003: Fix line numbers in JavaScript stack traces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/html/parser/HTMLScriptRunner.cpp

Issue 688033003: Fix line numbers in JavaScript stack traces (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Remove unnecessary Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/html/parser/HTMLScriptRunner.cpp

diff --git a/sky/engine/core/html/parser/HTMLScriptRunner.cpp b/sky/engine/core/html/parser/HTMLScriptRunner.cpp

index 7327513fe84e30e7ab3933204ea7f3b43b276291..9b63629359405df3855fbd47d708fa42b2f6efa4 100644

--- a/sky/engine/core/html/parser/HTMLScriptRunner.cpp

+++ b/sky/engine/core/html/parser/HTMLScriptRunner.cpp

@@ -59,7 +59,7 @@ void HTMLScriptRunner::executeScript(PassRefPtr<HTMLScriptElement> element, Text

TemporaryChange<bool> executingScript(m_isExecutingScript, true);

contextDocument->pushCurrentScript(element);

- frame->script().executeModuleScript(sourceDocument, source);

+ frame->script().executeModuleScript(sourceDocument, source, textPosition);

contextDocument->popCurrentScript();

}