Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 686623002: [Telemetry] Add labels attribute to page as the new way to set label (Closed)

Created:
6 years, 1 month ago by nednguyen
Modified:
6 years, 1 month ago
Reviewers:
dtu, ernstm, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Add labels attribute to page as the new way to set label BUG=418375 Committed: https://crrev.com/b545bb9359afe80c78cc8b931492c5a1842d69aa Cr-Commit-Position: refs/heads/master@{#301552}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -63 lines) Patch
M tools/perf/page_sets/key_mobile_sites.py View 6 chunks +7 lines, -20 lines 0 comments Download
M tools/perf/page_sets/tough_video_cases.py View 12 chunks +14 lines, -27 lines 0 comments Download
M tools/telemetry/telemetry/page/__init__.py View 3 chunks +11 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_filter.py View 1 chunk +2 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/page/page_filter_unittest.py View 2 chunks +6 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/unittest/page_set_smoke_test.py View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nednguyen
6 years, 1 month ago (2014-10-27 23:17:32 UTC) #2
ernstm
On 2014/10/27 23:17:32, nednguyen wrote: LGTM
6 years, 1 month ago (2014-10-27 23:24:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686623002/1
6 years, 1 month ago (2014-10-28 01:02:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-28 02:22:49 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 02:23:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b545bb9359afe80c78cc8b931492c5a1842d69aa
Cr-Commit-Position: refs/heads/master@{#301552}

Powered by Google App Engine
This is Rietveld 408576698