Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: tools/telemetry/telemetry/page/page_filter_unittest.py

Issue 686623002: [Telemetry] Add labels attribute to page as the new way to set label (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_filter_unittest.py
diff --git a/tools/telemetry/telemetry/page/page_filter_unittest.py b/tools/telemetry/telemetry/page/page_filter_unittest.py
index be3ec562ae16817a155c67b70ef035953d3dd640..d318f4219559d167326e9e7f784d1f1b5cd517bf 100644
--- a/tools/telemetry/telemetry/page/page_filter_unittest.py
+++ b/tools/telemetry/telemetry/page/page_filter_unittest.py
@@ -30,12 +30,15 @@ class PageFilterTest(unittest.TestCase):
ps = page_set.PageSet()
self.p1 = page.Page(
'file://conformance/textures/tex-sub-image-2d.html', page_set=ps,
- name='WebglConformance.conformance_textures_tex_sub_image_2d')
+ name='WebglConformance.conformance_textures_tex_sub_image_2d',
+ labels=['label1', 'label2'])
self.p2 = page.Page(
'file://othersuite/textures/tex-sub-image-3d.html', page_set=ps,
- name='OtherSuite.textures_tex_sub_image_3d')
+ name='OtherSuite.textures_tex_sub_image_3d',
+ labels=['label1'])
self.p3 = page.Page(
- 'file://othersuite/textures/tex-sub-image-3d.html', page_set=ps)
+ 'file://othersuite/textures/tex-sub-image-3d.html', page_set=ps,
+ labels=['label2'])
def testURLPattern(self):
options = MockUrlFilterOptions('conformance/textures', '')
@@ -78,13 +81,6 @@ class PageFilterTest(unittest.TestCase):
self.assertFalse(page_filter.PageFilter.IsSelected(self.p3))
def testLabelFilters(self):
- self.p1.label1 = True
- self.p2.label1 = True
- self.p3.label1 = False
- self.p1.label2 = True
- self.p2.label2 = False
- self.p3.label2 = True
-
# Include both labels
options = MockLabelFilterOptions('label1,label2', '')
page_filter.PageFilter.ProcessCommandLineArgs(None, options)
« no previous file with comments | « tools/telemetry/telemetry/page/page_filter.py ('k') | tools/telemetry/telemetry/unittest/page_set_smoke_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698