Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: tools/perf/page_sets/tough_video_cases.py

Issue 686623002: [Telemetry] Add labels attribute to page as the new way to set label (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/key_mobile_sites.py ('k') | tools/telemetry/telemetry/page/__init__.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/tough_video_cases.py
diff --git a/tools/perf/page_sets/tough_video_cases.py b/tools/perf/page_sets/tough_video_cases.py
index f13f07c70ac6b2729060e746e25592c056b0d892..094ebb0f409b1cea9de9ce5c04cb0602cc8346ee 100644
--- a/tools/perf/page_sets/tough_video_cases.py
+++ b/tools/perf/page_sets/tough_video_cases.py
@@ -7,8 +7,9 @@ from telemetry.page import page_set as page_set_module
class ToughVideoCasesPage(page_module.Page):
- def __init__(self, url, page_set):
- super(ToughVideoCasesPage, self).__init__(url=url, page_set=page_set)
+ def __init__(self, url, page_set, labels=None):
+ super(ToughVideoCasesPage, self).__init__(
+ url=url, page_set=page_set, labels=labels)
def LoopMixedAudio(self, action_runner):
action_runner.PlayMedia(selector='#background_audio',
@@ -80,10 +81,9 @@ class Page4(ToughVideoCasesPage):
def __init__(self, page_set):
super(Page4, self).__init__(
url='file://tough_video_cases/video.html?src=crowd1080.webm',
- page_set=page_set)
+ page_set=page_set, labels=['is_50fps'])
self.add_browser_metrics = True
- self.is_50fps = True
def RunPageInteractions(self, action_runner):
self.PlayAction(action_runner)
@@ -94,11 +94,9 @@ class Page5(ToughVideoCasesPage):
def __init__(self, page_set):
super(Page5, self).__init__(
url='file://tough_video_cases/video.html?src=crowd2160.ogv',
- page_set=page_set)
+ page_set=page_set, labels=['is_4k', 'is_50fps'])
self.add_browser_metrics = True
- self.is_4k = True
- self.is_50fps = True
def RunPageInteractions(self, action_runner):
self.PlayAction(action_runner)
@@ -109,11 +107,9 @@ class Page6(ToughVideoCasesPage):
def __init__(self, page_set):
super(Page6, self).__init__(
url='file://tough_video_cases/video.html?src=crowd2160.webm',
- page_set=page_set)
+ page_set=page_set, labels=['is_4k', 'is_50fps'])
self.add_browser_metrics = True
- self.is_4k = True
- self.is_50fps = True
def RunPageInteractions(self, action_runner):
self.PlayAction(action_runner)
@@ -176,10 +172,9 @@ class Page11(ToughVideoCasesPage):
def __init__(self, page_set):
super(Page11, self).__init__(
url='file://tough_video_cases/video.html?src=crowd1080.mp4',
- page_set=page_set)
+ page_set=page_set, labels=['is_50fps'])
self.add_browser_metrics = True
- self.is_50fps = True
def RunPageInteractions(self, action_runner):
self.PlayAction(action_runner)
@@ -190,11 +185,9 @@ class Page12(ToughVideoCasesPage):
def __init__(self, page_set):
super(Page12, self).__init__(
url='file://tough_video_cases/video.html?src=crowd2160.mp4',
- page_set=page_set)
+ page_set=page_set, labels=['is_4k', 'is_50fps'])
self.add_browser_metrics = True
- self.is_4k = True
- self.is_50fps = True
def RunPageInteractions(self, action_runner):
self.PlayAction(action_runner)
@@ -244,9 +237,8 @@ class Page16(ToughVideoCasesPage):
def __init__(self, page_set):
super(Page16, self).__init__(
url='file://tough_video_cases/video.html?src=garden2_10s.webm',
- page_set=page_set)
+ page_set=page_set, labels=['is_4k'])
- self.is_4k = True
self.add_browser_metrics = True
def RunPageInteractions(self, action_runner):
@@ -258,9 +250,8 @@ class Page17(ToughVideoCasesPage):
def __init__(self, page_set):
super(Page17, self).__init__(
url='file://tough_video_cases/video.html?src=garden2_10s.mp4',
- page_set=page_set)
+ page_set=page_set, labels=['is_4k'])
- self.is_4k = True
self.add_browser_metrics = True
def RunPageInteractions(self, action_runner):
@@ -272,9 +263,8 @@ class Page18(ToughVideoCasesPage):
def __init__(self, page_set):
super(Page18, self).__init__(
url='file://tough_video_cases/video.html?src=garden2_10s.ogv',
- page_set=page_set)
+ page_set=page_set, labels=['is_4k'])
- self.is_4k = True
self.add_browser_metrics = True
def RunPageInteractions(self, action_runner):
@@ -364,10 +354,9 @@ class Page25(ToughVideoCasesPage):
def __init__(self, page_set):
super(Page25, self).__init__(
url='file://tough_video_cases/video.html?src=garden2_10s.webm',
- page_set=page_set)
+ page_set=page_set, labels=['is_4k'])
self.skip_basic_metrics = True
- self.is_4k = True
def RunPageInteractions(self, action_runner):
self.SeekBeforeAndAfterPlayhead(action_runner)
@@ -378,10 +367,9 @@ class Page26(ToughVideoCasesPage):
def __init__(self, page_set):
super(Page26, self).__init__(
url='file://tough_video_cases/video.html?src=garden2_10s.mp4',
- page_set=page_set)
+ page_set=page_set, labels=['is_4k'])
self.skip_basic_metrics = True
- self.is_4k = True
def RunPageInteractions(self, action_runner):
self.SeekBeforeAndAfterPlayhead(action_runner)
@@ -392,10 +380,9 @@ class Page27(ToughVideoCasesPage):
def __init__(self, page_set):
super(Page27, self).__init__(
url='file://tough_video_cases/video.html?src=garden2_10s.ogv',
- page_set=page_set)
+ page_set=page_set, labels=['is_4k'])
self.skip_basic_metrics = True
- self.is_4k = True
def RunPageInteractions(self, action_runner):
self.SeekBeforeAndAfterPlayhead(action_runner)
« no previous file with comments | « tools/perf/page_sets/key_mobile_sites.py ('k') | tools/telemetry/telemetry/page/__init__.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698