Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Unified Diff: tools/telemetry/telemetry/unittest/page_set_smoke_test.py

Issue 686623002: [Telemetry] Add labels attribute to page as the new way to set label (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/page_filter_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/unittest/page_set_smoke_test.py
diff --git a/tools/telemetry/telemetry/unittest/page_set_smoke_test.py b/tools/telemetry/telemetry/unittest/page_set_smoke_test.py
index 717e8a09be3188fcfeec23a81ff438a79da27e51..c39e22118d3685d547c7bcaba25a91d23213be41 100644
--- a/tools/telemetry/telemetry/unittest/page_set_smoke_test.py
+++ b/tools/telemetry/telemetry/unittest/page_set_smoke_test.py
@@ -120,6 +120,14 @@ class PageSetSmokeTest(unittest.TestCase):
self.assertTrue(
isinstance(page.name, str),
msg='page %s \'s name field must have type string' % page.display_name)
+ self.assertTrue(
+ isinstance(page.labels, set),
+ msg='page %s \'s labels field must have type set' % page.display_name)
+ for l in page.labels:
+ self.assertTrue(
+ isinstance(l, str),
+ msg='label %s in page %s \'s labels must have type string'
+ % (str(l), page.display_name))
def RunSmokeTest(self, page_sets_dir, top_level_dir):
"""Run smoke test on all page sets in page_sets_dir.
« no previous file with comments | « tools/telemetry/telemetry/page/page_filter_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698