Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: tools/perf/page_sets/key_mobile_sites.py

Issue 686623002: [Telemetry] Add labels attribute to page as the new way to set label (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/tough_video_cases.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/key_mobile_sites.py
diff --git a/tools/perf/page_sets/key_mobile_sites.py b/tools/perf/page_sets/key_mobile_sites.py
index 2a90ef89b83a5175002c6746be41843cb6607b47..8d34f30a97a9338a55243d8aa8ed873e62e9e345 100644
--- a/tools/perf/page_sets/key_mobile_sites.py
+++ b/tools/perf/page_sets/key_mobile_sites.py
@@ -7,10 +7,10 @@ from telemetry.page import page_set as page_set_module
class KeyMobileSitesPage(page_module.Page):
- def __init__(self, url, page_set, name=''):
+ def __init__(self, url, page_set, name='', labels=None):
super(KeyMobileSitesPage, self).__init__(
url=url, page_set=page_set, name=name,
- credentials_path='data/credentials.json')
+ credentials_path='data/credentials.json', labels=labels)
self.user_agent_type = 'mobile'
self.archive_data_file = 'data/key_mobile_sites.json'
@@ -30,10 +30,7 @@ class Page1(KeyMobileSitesPage):
def __init__(self, page_set):
super(Page1, self).__init__(
- url='http://nytimes.com/',
- page_set=page_set)
-
- self.fastpath = True
+ url='http://nytimes.com/', page_set=page_set, labels=['fastpath'])
class Page2(KeyMobileSitesPage):
@@ -59,10 +56,7 @@ class Page3(KeyMobileSitesPage):
def __init__(self, page_set):
super(Page3, self).__init__(
- url='http://cuteoverload.com',
- page_set=page_set)
-
- self.fastpath = True
+ url='http://cuteoverload.com', page_set=page_set, labels=['fastpath'])
class Page4(KeyMobileSitesPage):
@@ -288,9 +282,7 @@ class Page18(KeyMobileSitesPage):
def __init__(self, page_set):
super(Page18, self).__init__(
url='http://slashdot.org/',
- page_set=page_set)
-
- self.fastpath = True
+ page_set=page_set, labels=['fastpath'])
class Page19(KeyMobileSitesPage):
@@ -300,9 +292,7 @@ class Page19(KeyMobileSitesPage):
def __init__(self, page_set):
super(Page19, self).__init__(
url='http://www.reddit.com/r/programming/comments/1g96ve',
- page_set=page_set)
-
- self.fastpath = True
+ page_set=page_set, labels=['fastpath'])
class Page20(KeyMobileSitesPage):
@@ -311,10 +301,7 @@ class Page20(KeyMobileSitesPage):
def __init__(self, page_set):
super(Page20, self).__init__(
- url='http://www.boingboing.net',
- page_set=page_set)
-
- self.fastpath = True
+ url='http://www.boingboing.net', page_set=page_set, labels=['fastpath'])
class Page21(KeyMobileSitesPage):
« no previous file with comments | « no previous file | tools/perf/page_sets/tough_video_cases.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698