Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 685553002: Standardize usage of virtual/override/final specifiers. (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
Reviewers:
noelutz, mattm
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final specifiers in chrome/browser/safe_browsing. The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=noelutz@google.com Committed: https://crrev.com/3456d92f5ba40d9fc3c5f6a1cd71c6d49a9dc7de Cr-Commit-Position: refs/heads/master@{#301964}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -44 lines) Patch
M chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/download_feedback_service_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/download_feedback_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/delayed_callback_runner_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/ping_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/protocol_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_test.cc View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
dcheng
6 years, 1 month ago (2014-10-27 21:15:59 UTC) #1
dcheng
+mattm, mind taking a look at this?
6 years, 1 month ago (2014-10-29 17:45:49 UTC) #3
mattm
CL summary should add " in chrome/browser/safe_browsing." otherwise lgtm.
6 years, 1 month ago (2014-10-29 21:00:59 UTC) #4
dcheng
On 2014/10/29 at 21:00:59, mattm wrote: > CL summary should add " in chrome/browser/safe_browsing." > ...
6 years, 1 month ago (2014-10-29 21:02:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685553002/1
6 years, 1 month ago (2014-10-29 21:04:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/29028) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/28448) chromium_presubmit ...
6 years, 1 month ago (2014-10-29 21:11:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685553002/20001
6 years, 1 month ago (2014-10-29 21:20:18 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-29 23:01:42 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 23:02:22 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3456d92f5ba40d9fc3c5f6a1cd71c6d49a9dc7de
Cr-Commit-Position: refs/heads/master@{#301964}

Powered by Google App Engine
This is Rietveld 408576698