chrome/browser/safe_browsing/incident_reporting/delayed_callback_runner_unittest.cc - Issue 685553002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/delayed_callback_runner_unittest.cc

Issue 685553002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service_unittest.cc ('k') | chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/delayed_callback_runner_unittest.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/delayed_callback_runner_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/delayed_callback_runner_unittest.cc

index df70f7923b27e9c85d7a2ae8e2c394075455dd6e..4cd23b26c9f2c4a3d68bdb49e6bf157e7b5ac657 100644

--- a/chrome/browser/safe_browsing/incident_reporting/delayed_callback_runner_unittest.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/delayed_callback_runner_unittest.cc

@@ -47,13 +47,13 @@ class DelayedCallbackRunnerTest : public testing::Test {

: task_runner_(new base::TestSimpleTaskRunner),

thread_task_runner_handle_(task_runner_) {}

- virtual void SetUp() override {

+ void SetUp() override {

instance_.reset(new safe_browsing::DelayedCallbackRunner(

base::TimeDelta::FromMilliseconds(1), // ignored by simple runner.

task_runner_));

}

- virtual void TearDown() override { instance_.reset(); }

+ void TearDown() override { instance_.reset(); }

void OnRun(const std::string& name, CallbackArgument* arg) {

EXPECT_FALSE(callbacks_[name].run);