chrome/browser/safe_browsing/download_protection_service_unittest.cc - Issue 685553002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/download_protection_service_unittest.cc

Issue 685553002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/download_feedback_unittest.cc ('k') | chrome/browser/safe_browsing/incident_reporting/delayed_callback_runner_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/download_protection_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/download_protection_service_unittest.cc b/chrome/browser/safe_browsing/download_protection_service_unittest.cc

index 93324cf30188e5bac858c5dba027b76f1de50c2b..b311980cd0c95a263a26bf68e6bdbb7619a1f423 100644

--- a/chrome/browser/safe_browsing/download_protection_service_unittest.cc

+++ b/chrome/browser/safe_browsing/download_protection_service_unittest.cc

@@ -201,7 +201,7 @@ class DownloadProtectionServiceTest : public testing::Test {

: test_browser_thread_bundle_(

content::TestBrowserThreadBundle::IO_MAINLOOP) {

}

- virtual void SetUp() {

+ void SetUp() override {

#if defined(OS_MACOSX)

field_trial_list_.reset(new base::FieldTrialList(

new metrics::SHA1EntropyProvider("42")));

@@ -230,7 +230,7 @@ class DownloadProtectionServiceTest : public testing::Test {

.AppendASCII("download_protection");

}

- virtual void TearDown() {

+ void TearDown() override {

sb_service_->ShutDown();

// Flush all of the thread message loops to ensure that there are no

// tasks currently running.