chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc - Issue 685553002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc

Issue 685553002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc ('k') | chrome/browser/safe_browsing/malware_details_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc

index e152635c636e5d0ffecd54ede6d6eb496584938d..5b687bd4a1e6c7bc3416b19329078a53ac3823fa 100644

--- a/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc

@@ -26,7 +26,7 @@ class PreferenceValidationDelegateTest : public testing::Test {

: kPrefPath_("atomic.pref"),

null_value_(base::Value::CreateNullValue()) {}

- virtual void SetUp() override {

+ void SetUp() override {

testing::Test::SetUp();

invalid_keys_.push_back(std::string("one"));

invalid_keys_.push_back(std::string("two"));

@@ -103,7 +103,7 @@ class PreferenceValidationDelegateValues

public testing::WithParamInterface<

std::tr1::tuple<base::Value::Type, const char*> > {

protected:

- virtual void SetUp() override {

+ void SetUp() override {

PreferenceValidationDelegateTest::SetUp();

value_type_ = std::tr1::get<0>(GetParam());

expected_value_ = std::tr1::get<1>(GetParam());

@@ -183,7 +183,7 @@ class PreferenceValidationDelegateNoIncident

: public PreferenceValidationDelegateTest,

public testing::WithParamInterface<PrefHashStoreTransaction::ValueState> {

protected:

- virtual void SetUp() override {

+ void SetUp() override {

PreferenceValidationDelegateTest::SetUp();

value_state_ = GetParam();

}

@@ -223,7 +223,7 @@ class PreferenceValidationDelegateWithIncident

std::tr1::tuple<PrefHashStoreTransaction::ValueState,

TrackedPreferenceHelper::ResetAction> > {

protected:

- virtual void SetUp() override {

+ void SetUp() override {

PreferenceValidationDelegateTest::SetUp();

value_state_ = std::tr1::get<0>(GetParam());

reset_action_ = std::tr1::get<1>(GetParam());