chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc - Issue 685553002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

Issue 685553002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/protocol_manager_unittest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

index 8b3c56a9456d461cabd1033156aea1fe3094aa69..07c02654993f98f8046d37af61a9587170a9e1ee 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

@@ -344,14 +344,14 @@ class SafeBrowsingBlockingPageBrowserTest

SafeBrowsingBlockingPageBrowserTest() {

}

- virtual void SetUp() override {

+ void SetUp() override {

SafeBrowsingService::RegisterFactory(&factory_);

SafeBrowsingBlockingPage::RegisterFactory(&blocking_page_factory_);

MalwareDetails::RegisterFactory(&details_factory_);

InProcessBrowserTest::SetUp();

}

- virtual void TearDown() override {

+ void TearDown() override {

InProcessBrowserTest::TearDown();

SafeBrowsingBlockingPage::RegisterFactory(NULL);

SafeBrowsingService::RegisterFactory(NULL);