Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 678473003: minidump: Be consistent about setting the fields of WritableIoVec (Closed)

Created:
6 years, 2 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

minidump: Be consistent about setting the fields of WritableIoVec. The iov_base field appears before the iov_len field, but for some reason, sometimes the fields were being set in the reverse order. TEST=minidump_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/dcdbd2098f64b61a708ab2e1c0d0bd2acdc469f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M minidump/minidump_file_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_memory_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_module_writer.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M minidump/minidump_simple_string_dictionary_writer.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M minidump/minidump_thread_writer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
I hit this earlier today, and wound up reversing the fields. There’s no good reason ...
6 years, 2 months ago (2014-10-23 20:48:27 UTC) #2
Robert Sesek
LGTM
6 years, 2 months ago (2014-10-23 20:53:11 UTC) #3
Mark Mentovai
6 years, 2 months ago (2014-10-23 21:25:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dcdbd2098f64b61a708ab2e1c0d0bd2acdc469f2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698