minidump: Be consistent about setting the fields of WritableIoVec

minidump/minidump_thread_writer.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 146 matching lines @@
 
 bool MinidumpThreadListWriter::WriteObject(FileWriterInterface* file_writer) {
   DCHECK_EQ(state(), kStateWritable);
 
   WritableIoVec iov;
   iov.iov_base = &thread_list_base_;
   iov.iov_len = sizeof(thread_list_base_);
   std::vector<WritableIoVec> iovecs(1, iov);
 
   for (const MinidumpThreadWriter* thread : threads_) {
+    iov.iov_base = thread->MinidumpThread();
     iov.iov_len = sizeof(MINIDUMP_THREAD);
-    iov.iov_base = thread->MinidumpThread();
     iovecs.push_back(iov);
   }
 
   return file_writer->WriteIoVec(&iovecs);
 }
 
 MinidumpStreamType MinidumpThreadListWriter::StreamType() const {
   return kMinidumpStreamTypeThreadList;
 }
 
 }  // namespace crashpad