Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Side by Side Diff: minidump/minidump_file_writer.cc

Issue 678473003: minidump: Be consistent about setting the fields of WritableIoVec (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | minidump/minidump_memory_writer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 bool MinidumpFileWriter::WriteObject(FileWriterInterface* file_writer) { 143 bool MinidumpFileWriter::WriteObject(FileWriterInterface* file_writer) {
144 DCHECK_EQ(state(), kStateWritable); 144 DCHECK_EQ(state(), kStateWritable);
145 DCHECK_EQ(streams_.size(), stream_types_.size()); 145 DCHECK_EQ(streams_.size(), stream_types_.size());
146 146
147 WritableIoVec iov; 147 WritableIoVec iov;
148 iov.iov_base = &header_; 148 iov.iov_base = &header_;
149 iov.iov_len = sizeof(header_); 149 iov.iov_len = sizeof(header_);
150 std::vector<WritableIoVec> iovecs(1, iov); 150 std::vector<WritableIoVec> iovecs(1, iov);
151 151
152 for (internal::MinidumpStreamWriter* stream : streams_) { 152 for (internal::MinidumpStreamWriter* stream : streams_) {
153 iov.iov_base = stream->DirectoryListEntry();
153 iov.iov_len = sizeof(MINIDUMP_DIRECTORY); 154 iov.iov_len = sizeof(MINIDUMP_DIRECTORY);
154 iov.iov_base = stream->DirectoryListEntry();
155 iovecs.push_back(iov); 155 iovecs.push_back(iov);
156 } 156 }
157 157
158 return file_writer->WriteIoVec(&iovecs); 158 return file_writer->WriteIoVec(&iovecs);
159 } 159 }
160 160
161 } // namespace crashpad 161 } // namespace crashpad
OLDNEW
« no previous file with comments | « no previous file | minidump/minidump_memory_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698