minidump: Be consistent about setting the fields of WritableIoVec

minidump/minidump_simple_string_dictionary_writer.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 126 matching lines @@
 
 bool MinidumpSimpleStringDictionaryWriter::WriteObject(
     FileWriterInterface* file_writer) {
   DCHECK_GE(state(), kStateWritable);
 
   WritableIoVec iov;
   iov.iov_base = &simple_string_dictionary_base_;
   iov.iov_len = sizeof(simple_string_dictionary_base_);
   std::vector<WritableIoVec> iovecs(1, iov);
 
-  if (!entries_.empty()) {
+  for (const auto& key_entry : entries_) {
+    iov.iov_base = key_entry.second->MinidumpSimpleStringDictionaryEntry();
     iov.iov_len = sizeof(MinidumpSimpleStringDictionaryEntry);
-    for (const auto& key_entry : entries_) {
-      iov.iov_base = key_entry.second->MinidumpSimpleStringDictionaryEntry();
-      iovecs.push_back(iov);
-    }
+    iovecs.push_back(iov);
   }
 
   return file_writer->WriteIoVec(&iovecs);
 }
 
 }  // namespace crashpad