Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: minidump/minidump_memory_writer.cc

Issue 678473003: minidump: Be consistent about setting the fields of WritableIoVec (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « minidump/minidump_file_writer.cc ('k') | minidump/minidump_module_writer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 156
157 bool MinidumpMemoryListWriter::WriteObject(FileWriterInterface* file_writer) { 157 bool MinidumpMemoryListWriter::WriteObject(FileWriterInterface* file_writer) {
158 DCHECK_EQ(state(), kStateWritable); 158 DCHECK_EQ(state(), kStateWritable);
159 159
160 WritableIoVec iov; 160 WritableIoVec iov;
161 iov.iov_base = &memory_list_base_; 161 iov.iov_base = &memory_list_base_;
162 iov.iov_len = sizeof(memory_list_base_); 162 iov.iov_len = sizeof(memory_list_base_);
163 std::vector<WritableIoVec> iovecs(1, iov); 163 std::vector<WritableIoVec> iovecs(1, iov);
164 164
165 for (const MinidumpMemoryWriter* memory_writer : memory_writers_) { 165 for (const MinidumpMemoryWriter* memory_writer : memory_writers_) {
166 iov.iov_base = memory_writer->MinidumpMemoryDescriptor();
166 iov.iov_len = sizeof(MINIDUMP_MEMORY_DESCRIPTOR); 167 iov.iov_len = sizeof(MINIDUMP_MEMORY_DESCRIPTOR);
167 iov.iov_base = memory_writer->MinidumpMemoryDescriptor();
168 iovecs.push_back(iov); 168 iovecs.push_back(iov);
169 } 169 }
170 170
171 return file_writer->WriteIoVec(&iovecs); 171 return file_writer->WriteIoVec(&iovecs);
172 } 172 }
173 173
174 MinidumpStreamType MinidumpMemoryListWriter::StreamType() const { 174 MinidumpStreamType MinidumpMemoryListWriter::StreamType() const {
175 return kMinidumpStreamTypeMemoryList; 175 return kMinidumpStreamTypeMemoryList;
176 } 176 }
177 177
178 } // namespace crashpad 178 } // namespace crashpad
OLDNEW
« no previous file with comments | « minidump/minidump_file_writer.cc ('k') | minidump/minidump_module_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698