Moving some functions from browser to app. Adding function prototypes to app backend.

Moving following functions from browser to app:
  __enter__
  __exit__
  GetStandardOutput
  GetStackTrace

Adding following functions to app backend:
  __del__
  app_type
  Start
  Close
  pid
  IsAppRunning
  GetStandardOutput
  GetStackTrace

Added adapters for browser.browser and browser.browser_type.

Removed references to browser_backend._browser.
BUG=417542
Committed: https://crrev.com/f2e03e25c410d8c98dd175328b1ab5ac685e03d8
Cr-Commit-Position: refs/heads/master@{#303327}

[wuhu, 2014-10-22 22:20:05]

wuhu@google.com changed reviewers:
+ dtu@chromium.org, nednguyen@google.com

[wuhu, 2014-10-22 22:20:05]

Refactoring tidy up.

[nednguyen, 2014-10-22 22:43:27]

On 2014/10/22 22:20:05, wuhu wrote:
> Refactoring tidy up.

Please improve the description by specifying which functions you are moving from
browser to app.

[nednguyen, 2014-11-07 19:07:05]

lgtm

https://codereview.chromium.org/675613003/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/app_backend.py (right):

https://codereview.chromium.org/675613003/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/app_backend.py:39: def
GetStandardOutput(self):
Probably not in this patch but I think we may be able to delegate this to
platform for many of these methods. 

s.t like:

def GetStandardOutput(self):
   return self._platform.GetStandardOutput(self.pid)

[nednguyen, 2014-11-07 19:07:06]

lgtm

https://codereview.chromium.org/675613003/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/app_backend.py (right):

https://codereview.chromium.org/675613003/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/app_backend.py:39: def
GetStandardOutput(self):
Probably not in this patch but I think we may be able to delegate this to
platform for many of these methods. 

s.t like:

def GetStandardOutput(self):
   return self._platform.GetStandardOutput(self.pid)

[wuhu, 2014-11-07 21:59:15]

On 2014/11/07 19:07:06, nednguyen wrote:
> lgtm
> 
>
https://codereview.chromium.org/675613003/diff/20001/tools/telemetry/telemetr...
> File tools/telemetry/telemetry/core/backends/app_backend.py (right):
> 
>
https://codereview.chromium.org/675613003/diff/20001/tools/telemetry/telemetr...
> tools/telemetry/telemetry/core/backends/app_backend.py:39: def
> GetStandardOutput(self):
> Probably not in this patch but I think we may be able to delegate this to
> platform for many of these methods. 
> 
> s.t like:
> 
> def GetStandardOutput(self):
>    return self._platform.GetStandardOutput(self.pid)

Absolutely.

[wuhu, 2014-11-07 21:59:22]

The CQ bit was checked by wuhu@google.com

[commit-bot: I haz the power, 2014-11-07 22:00:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/675613003/20001

[commit-bot: I haz the power, 2014-11-07 22:05:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-07 22:05:51]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/79014)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32 on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[wuhu, 2014-11-07 22:12:41]

The CQ bit was checked by wuhu@google.com

[commit-bot: I haz the power, 2014-11-07 22:14:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/675613003/40001

[commit-bot: I haz the power, 2014-11-07 23:50:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-07 23:51:32]

Patchset 3 (id:??) landed as
https://crrev.com/f2e03e25c410d8c98dd175328b1ab5ac685e03d8
Cr-Commit-Position: refs/heads/master@{#303327}