tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py - Issue 675613003: Moving some functions from browser to app. Adding function prototypes to app backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

Issue 675613003: Moving some functions from browser to app. Adding function prototypes to app backend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/browser_backend.py ('k') | tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

index d285df52032186bc3708f28723a79e60a7dedf51..4639f46476c6a6a7df051ad06699ea432c454e3f 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

@@ -313,7 +313,7 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):

def StopTracing(self):

""" Stops tracing and returns the result as TimelineData object. """

tab_ids_list = []

- for (i, _) in enumerate(self._browser.tabs):

+ for (i, _) in enumerate(self.browser.tabs):

tab = self.tab_list_backend.Get(i, None)

if tab:

success = tab.EvaluateJavaScript(