tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py - Issue 675613003: Moving some functions from browser to app. Adding function prototypes to app backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

Issue 675613003: Moving some functions from browser to app. Adding function prototypes to app backend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py ('k') | tools/telemetry/telemetry/core/browser.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

index cde1a37243dcb51fa14e91b7140666914af1ba6e..e4e0ff2bbbb15c44ea74196bf128bd57f4f93e09 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

@@ -98,10 +98,10 @@ class DesktopBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

return r'\\.\pipe\%s_service' % os.path.basename(self._tmp_minidump_dir)

def _StartCrashService(self):

- os_name = self._browser.platform.GetOSName()

+ os_name = self.browser.platform.GetOSName()

if os_name != 'win':

return None

- arch_name = self._browser.platform.GetArchName()

+ arch_name = self.browser.platform.GetArchName()

return subprocess.Popen([

support_binaries.FindPath('crash_service', arch_name, os_name),

'--no-window',

@@ -246,7 +246,7 @@ class DesktopBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

return most_recent_dump

def _GetStackFromMinidump(self, minidump):

- os_name = self._browser.platform.GetOSName()

+ os_name = self.browser.platform.GetOSName()

if os_name == 'win':

cdb = self._GetCdbPath()

if not cdb:

@@ -258,7 +258,7 @@ class DesktopBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

stack_end = output.find('quit:')

return output[stack_start:stack_end]

- arch_name = self._browser.platform.GetArchName()

+ arch_name = self.browser.platform.GetArchName()

stackwalk = support_binaries.FindPath(

'minidump_stackwalk', arch_name, os_name)

if not stackwalk: