Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: tools/telemetry/telemetry/core/browser.py

Issue 675613003: Moving some functions from browser to app. Adding function prototypes to app backend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/browser.py
diff --git a/tools/telemetry/telemetry/core/browser.py b/tools/telemetry/telemetry/core/browser.py
index 74fb63c2b45561126d5f124180d45dd3763a3850..5cb81e37686348dc4297b7c4c7e14188a757d6b1 100644
--- a/tools/telemetry/telemetry/core/browser.py
+++ b/tools/telemetry/telemetry/core/browser.py
@@ -52,15 +52,9 @@ class Browser(app.App):
self._browser_backend.Start()
self._platform_backend.DidStartBrowser(self, self._browser_backend)
- def __enter__(self):
- return self
-
- def __exit__(self, *args):
- self.Close()
-
@property
def browser_type(self):
- return self._browser_backend.browser_type
+ return self.app_type
@property
def supports_extensions(self):
« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698