Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: tools/telemetry/telemetry/core/backends/app_backend.py

Issue 675613003: Moving some functions from browser to app. Adding function prototypes to app backend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/app.py ('k') | tools/telemetry/telemetry/core/backends/browser_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/backends/app_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/app_backend.py b/tools/telemetry/telemetry/core/backends/app_backend.py
index 815c2dc400a38bc08fdab8aec5cb0f3e97131ca9..64314ca902c29b21869752f8450c8edc16913f05 100644
--- a/tools/telemetry/telemetry/core/backends/app_backend.py
+++ b/tools/telemetry/telemetry/core/backends/app_backend.py
@@ -4,9 +4,13 @@
class AppBackend(object):
- def __init__(self):
+ def __init__(self, app_type):
super(AppBackend, self).__init__()
self._app = None
+ self._app_type = app_type
+
+ def __del__(self):
+ self.Close()
def SetApp(self, app):
self._app = app
@@ -14,3 +18,26 @@ class AppBackend(object):
@property
def app(self):
return self._app
+
+ @property
+ def app_type(self):
+ return self._app_type
+
+ def Start(self):
+ NotImplementedError()
+
+ def Close(self):
+ NotImplementedError()
+
+ @property
+ def pid(self):
+ NotImplementedError()
+
+ def IsAppRunning(self):
+ NotImplementedError()
+
+ def GetStandardOutput(self):
+ NotImplementedError()
+
+ def GetStackTrace(self):
+ NotImplementedError()
« no previous file with comments | « tools/telemetry/telemetry/core/app.py ('k') | tools/telemetry/telemetry/core/backends/browser_backend.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698