Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Issue 671513002: [NaCk SDK] nacl_io: Don't assume ~S_IFMT are the mode bits. (Closed)

Created:
6 years, 2 months ago by Sam Clegg
Modified:
6 years, 2 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_umask
Project:
chromium
Visibility:
Public.

Description

[NaCk SDK] nacl_io: Don't assume ~S_IFMT are the mode bits. Define a new macro S_MODEBITS to represent the mode bits settable by chmod/fchmod. Add test to verify that file type cannot be changed with chmod. Committed: https://crrev.com/b979b669be38c55ba28a3562a310edf3b9403511 Cr-Commit-Position: refs/heads/master@{#300341}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
Sam Clegg
6 years, 2 months ago (2014-10-20 18:15:09 UTC) #3
binji
lgtm
6 years, 2 months ago (2014-10-20 18:18:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671513002/1
6 years, 2 months ago (2014-10-20 20:30:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 21:49:41 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 21:50:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b979b669be38c55ba28a3562a310edf3b9403511
Cr-Commit-Position: refs/heads/master@{#300341}

Powered by Google App Engine
This is Rietveld 408576698