native_client_sdk/src/libraries/nacl_io/memfs/mem_fs_node.cc - Issue 671513002: [NaCk SDK] nacl_io: Don't assume ~S_IFMT are the mode bits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/libraries/nacl_io/memfs/mem_fs_node.cc

Issue 671513002: [NaCk SDK] nacl_io: Don't assume ~S_IFMT are the mode bits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_umask

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: native_client_sdk/src/libraries/nacl_io/memfs/mem_fs_node.cc

diff --git a/native_client_sdk/src/libraries/nacl_io/memfs/mem_fs_node.cc b/native_client_sdk/src/libraries/nacl_io/memfs/mem_fs_node.cc

index 175ab722b84ab1f3009b340ee45ea88611426be1..f1435e961c6497f80b6be28cdec4e0215ad35be2 100644

--- a/native_client_sdk/src/libraries/nacl_io/memfs/mem_fs_node.cc

+++ b/native_client_sdk/src/libraries/nacl_io/memfs/mem_fs_node.cc

@@ -135,7 +135,7 @@ Error MemFsNode::Futimens(const struct timespec times[2]) {

Error MemFsNode::Fchmod(mode_t mode) {

AUTO_LOCK(node_lock_);

- SetMode(mode & ~S_IFMT);

+ SetMode(mode);

return 0;

}

« no previous file with comments | « native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc ('k') | native_client_sdk/src/libraries/nacl_io/node.h » ('j') | no next file with comments »