native_client_sdk/src/libraries/nacl_io/kernel_object.cc - Issue 671513002: [NaCk SDK] nacl_io: Don't assume ~S_IFMT are the mode bits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/libraries/nacl_io/kernel_object.cc

Issue 671513002: [NaCk SDK] nacl_io: Don't assume ~S_IFMT are the mode bits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_umask

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « native_client_sdk/src/libraries/nacl_io/fusefs/fuse_fs.cc ('k') | native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: native_client_sdk/src/libraries/nacl_io/kernel_object.cc

diff --git a/native_client_sdk/src/libraries/nacl_io/kernel_object.cc b/native_client_sdk/src/libraries/nacl_io/kernel_object.cc

index 5a33aa741e4c3bee5d0fcf91f72bc26abbffba57..8c670f8f789f89dc91cf41755e817dc351a1c3d2 100644

--- a/native_client_sdk/src/libraries/nacl_io/kernel_object.cc

+++ b/native_client_sdk/src/libraries/nacl_io/kernel_object.cc

@@ -162,7 +162,7 @@ mode_t KernelObject::GetUmask() {

mode_t KernelObject::SetUmask(mode_t newmask) {

AUTO_LOCK(umask_lock_);

mode_t oldmask = umask_;

- umask_ = newmask & 0777;

+ umask_ = newmask & S_MODEBITS;

return oldmask;

}