native_client_sdk/src/tests/nacl_io_test/http_fs_test.cc - Issue 671513002: [NaCk SDK] nacl_io: Don't assume ~S_IFMT are the mode bits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/tests/nacl_io_test/http_fs_test.cc

Issue 671513002: [NaCk SDK] nacl_io: Don't assume ~S_IFMT are the mode bits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_umask

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « native_client_sdk/src/tests/nacl_io_test/html5_fs_test.cc ('k') | native_client_sdk/src/tests/nacl_io_test/kernel_proxy_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: native_client_sdk/src/tests/nacl_io_test/http_fs_test.cc

diff --git a/native_client_sdk/src/tests/nacl_io_test/http_fs_test.cc b/native_client_sdk/src/tests/nacl_io_test/http_fs_test.cc

index 0c521dca4dea6b76b4024ecaa8f35107a002019c..6d752988c154510e8fa2426e7e89a56228178d07 100644

--- a/native_client_sdk/src/tests/nacl_io_test/http_fs_test.cc

+++ b/native_client_sdk/src/tests/nacl_io_test/http_fs_test.cc

@@ -243,7 +243,8 @@ TEST_P(HttpFsLargeFileTest, GetStat) {

struct stat statbuf;

EXPECT_EQ(0, node->GetStat(&statbuf));

- EXPECT_EQ(S_IFREG | S_IRUSR | S_IRGRP | S_IROTH, statbuf.st_mode);

+ EXPECT_TRUE(S_ISREG(statbuf.st_mode));

+ EXPECT_EQ(S_IRUSR | S_IRGRP | S_IROTH, statbuf.st_mode & S_MODEBITS);

EXPECT_EQ(size, statbuf.st_size);

// These are not currently set.

EXPECT_EQ(0, statbuf.st_atime);