native_client_sdk/src/tests/nacl_io_test/mem_fs_node_test.cc - Issue 671513002: [NaCk SDK] nacl_io: Don't assume ~S_IFMT are the mode bits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/tests/nacl_io_test/mem_fs_node_test.cc

Issue 671513002: [NaCk SDK] nacl_io: Don't assume ~S_IFMT are the mode bits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_umask

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: native_client_sdk/src/tests/nacl_io_test/mem_fs_node_test.cc

diff --git a/native_client_sdk/src/tests/nacl_io_test/mem_fs_node_test.cc b/native_client_sdk/src/tests/nacl_io_test/mem_fs_node_test.cc

index 3cd3b7acd58b2cb6ed93a9019529545edfb0fcb8..35d92ca5ee97112d3e5f3b5de8de9113bd94d937 100644

--- a/native_client_sdk/src/tests/nacl_io_test/mem_fs_node_test.cc

+++ b/native_client_sdk/src/tests/nacl_io_test/mem_fs_node_test.cc

@@ -137,7 +137,8 @@ TEST(MemFsNodeTest, Fchmod) {

struct stat s;

ASSERT_EQ(0, file.GetStat(&s));

- EXPECT_EQ(S_IFREG | S_IRALL | S_IWALL, s.st_mode);

+ EXPECT_TRUE(S_ISREG(s.st_mode));

+ EXPECT_EQ(S_IRALL | S_IWALL, s.st_mode & S_MODEBITS);

// Change to read-only.

EXPECT_EQ(0, file.Fchmod(S_IRALL));

« no previous file with comments | « native_client_sdk/src/tests/nacl_io_test/kernel_proxy_test.cc ('k') | no next file » | no next file with comments »