Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 667583003: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed)

Created:
6 years, 2 months ago by RAGHURAM
Modified:
6 years, 2 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git/+/master
Project:
blink
Visibility:
Public.

Description

Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings This step is to move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings (Ref: binding-methods changed: NPObject* npCreateV8ScriptObject(NPP, v8::Handle<v8::Object>, LocalDOMWindow*, v8::Isolate*) void disposeUnderlyingV8Object(NPObject*, v8::Isolate*) static void interruptAndRun(PassOwnPtr<Task>, v8::Isolate*) static bool extractTransferables(v8::Local<v8::Value>, int, MessagePortArray&, ArrayBufferArray&, ExceptionState&, v8::Isolate*)) BUG=424446 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183987

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M Source/bindings/core/v8/NPV8Object.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/NPV8Object.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/PageScriptDebugServer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/PostMessage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptController.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/ScriptDebugServer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptDebugServer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/SerializedScriptValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/SerializedScriptValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8NPUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/WorkerScriptDebugServer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8WindowCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebBindings.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
RAGHURAM
Please Review. Thanks & Regards
6 years, 2 months ago (2014-10-20 11:23:21 UTC) #2
haraken
LGTM
6 years, 2 months ago (2014-10-20 11:24:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667583003/1
6 years, 2 months ago (2014-10-20 11:25:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/32570)
6 years, 2 months ago (2014-10-20 13:14:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667583003/1
6 years, 2 months ago (2014-10-20 13:36:41 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 14:47:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183987

Powered by Google App Engine
This is Rietveld 408576698