Source/bindings/core/v8/NPV8Object.h - Issue 667583003: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/NPV8Object.h

Issue 667583003: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/NPV8Object.h

diff --git a/Source/bindings/core/v8/NPV8Object.h b/Source/bindings/core/v8/NPV8Object.h

index ff9cf8cf91a89cee3b00e28fa2d19e4fc985b1a7..d1abca7a7f4948f4e2e8c06315461089bf27ddc7 100644

--- a/Source/bindings/core/v8/NPV8Object.h

+++ b/Source/bindings/core/v8/NPV8Object.h

@@ -66,7 +66,7 @@ struct PrivateIdentifier {

bool isString;

};

-NPObject* npCreateV8ScriptObject(NPP, v8::Handle<v8::Object>, LocalDOMWindow*, v8::Isolate*);

+NPObject* npCreateV8ScriptObject(v8::Isolate*, NPP, v8::Handle<v8::Object>, LocalDOMWindow*);

NPObject* v8ObjectToNPObject(v8::Handle<v8::Object>);

@@ -76,7 +76,7 @@ V8NPObject* npObjectToV8NPObject(NPObject*);

ScriptWrappableBase* npObjectToScriptWrappableBase(NPObject*);

-void disposeUnderlyingV8Object(NPObject*, v8::Isolate*);

+void disposeUnderlyingV8Object(v8::Isolate*, NPObject*);

} // namespace blink

« no previous file with comments | « no previous file | Source/bindings/core/v8/NPV8Object.cpp » ('j') | no next file with comments »