Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: Source/bindings/core/v8/PageScriptDebugServer.cpp

Issue 667583003: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/core/v8/NPV8Object.cpp ('k') | Source/bindings/core/v8/PostMessage.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2011 Google Inc. All rights reserved. 2 * Copyright (c) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 153
154 if (m_listenersMap.isEmpty()) { 154 if (m_listenersMap.isEmpty()) {
155 discardDebuggerScript(); 155 discardDebuggerScript();
156 v8::Debug::SetDebugEventListener(0); 156 v8::Debug::SetDebugEventListener(0);
157 // FIXME: Remove all breakpoints set by the agent. 157 // FIXME: Remove all breakpoints set by the agent.
158 } 158 }
159 } 159 }
160 160
161 void PageScriptDebugServer::interruptAndRun(PassOwnPtr<Task> task) 161 void PageScriptDebugServer::interruptAndRun(PassOwnPtr<Task> task)
162 { 162 {
163 ScriptDebugServer::interruptAndRun(task, s_mainThreadIsolate); 163 ScriptDebugServer::interruptAndRun(s_mainThreadIsolate, task);
164 } 164 }
165 165
166 void PageScriptDebugServer::setClientMessageLoop(PassOwnPtr<ClientMessageLoop> c lientMessageLoop) 166 void PageScriptDebugServer::setClientMessageLoop(PassOwnPtr<ClientMessageLoop> c lientMessageLoop)
167 { 167 {
168 m_clientMessageLoop = clientMessageLoop; 168 m_clientMessageLoop = clientMessageLoop;
169 } 169 }
170 170
171 void PageScriptDebugServer::compileScript(ScriptState* scriptState, const String & expression, const String& sourceURL, String* scriptId, String* exceptionDetail sText, int* lineNumber, int* columnNumber, RefPtrWillBeRawPtr<ScriptCallStack>* stackTrace) 171 void PageScriptDebugServer::compileScript(ScriptState* scriptState, const String & expression, const String& sourceURL, String* scriptId, String* exceptionDetail sText, int* lineNumber, int* columnNumber, RefPtrWillBeRawPtr<ScriptCallStack>* stackTrace)
172 { 172 {
173 ExecutionContext* executionContext = scriptState->executionContext(); 173 ExecutionContext* executionContext = scriptState->executionContext();
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 UseCounter::muteForInspector(); 319 UseCounter::muteForInspector();
320 } 320 }
321 321
322 void PageScriptDebugServer::unmuteWarningsAndDeprecations() 322 void PageScriptDebugServer::unmuteWarningsAndDeprecations()
323 { 323 {
324 FrameConsole::unmute(); 324 FrameConsole::unmute();
325 UseCounter::unmuteForInspector(); 325 UseCounter::unmuteForInspector();
326 } 326 }
327 327
328 } // namespace blink 328 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/NPV8Object.cpp ('k') | Source/bindings/core/v8/PostMessage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698