Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: Source/bindings/core/v8/ScriptDebugServer.cpp

Issue 667583003: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (c) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 388 matching lines...) Expand 10 before | Expand all | Expand 10 after
399 } else { 399 } else {
400 v8::Handle<v8::Value> argv[] = { m_executionState, v8::Integer::New(m_is olate, index) }; 400 v8::Handle<v8::Value> argv[] = { m_executionState, v8::Integer::New(m_is olate, index) };
401 currentCallFrameV8 = callDebuggerMethod("currentCallFrameByIndex", WTF_A RRAY_LENGTH(argv), argv); 401 currentCallFrameV8 = callDebuggerMethod("currentCallFrameByIndex", WTF_A RRAY_LENGTH(argv), argv);
402 } 402 }
403 ASSERT(!currentCallFrameV8.IsEmpty()); 403 ASSERT(!currentCallFrameV8.IsEmpty());
404 if (!currentCallFrameV8->IsObject()) 404 if (!currentCallFrameV8->IsObject())
405 return nullptr; 405 return nullptr;
406 return JavaScriptCallFrame::create(v8::Debug::GetDebugContext(), v8::Handle< v8::Object>::Cast(currentCallFrameV8)); 406 return JavaScriptCallFrame::create(v8::Debug::GetDebugContext(), v8::Handle< v8::Object>::Cast(currentCallFrameV8));
407 } 407 }
408 408
409 void ScriptDebugServer::interruptAndRun(PassOwnPtr<Task> task, v8::Isolate* isol ate) 409 void ScriptDebugServer::interruptAndRun(v8::Isolate* isolate, PassOwnPtr<Task> t ask)
410 { 410 {
411 v8::Debug::DebugBreakForCommand(isolate, new ClientDataImpl(task)); 411 v8::Debug::DebugBreakForCommand(isolate, new ClientDataImpl(task));
412 } 412 }
413 413
414 void ScriptDebugServer::runPendingTasks() 414 void ScriptDebugServer::runPendingTasks()
415 { 415 {
416 v8::Debug::ProcessDebugMessages(); 416 v8::Debug::ProcessDebugMessages();
417 } 417 }
418 418
419 static ScriptDebugServer* toScriptDebugServer(v8::Handle<v8::Value> data) 419 static ScriptDebugServer* toScriptDebugServer(v8::Handle<v8::Value> data)
(...skipping 298 matching lines...) Expand 10 before | Expand all | Expand 10 after
718 { 718 {
719 return PassOwnPtr<ScriptSourceCode>(); 719 return PassOwnPtr<ScriptSourceCode>();
720 } 720 }
721 721
722 String ScriptDebugServer::preprocessEventListener(LocalFrame*, const String& sou rce, const String& url, const String& functionName) 722 String ScriptDebugServer::preprocessEventListener(LocalFrame*, const String& sou rce, const String& url, const String& functionName)
723 { 723 {
724 return source; 724 return source;
725 } 725 }
726 726
727 } // namespace blink 727 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/ScriptDebugServer.h ('k') | Source/bindings/core/v8/SerializedScriptValue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698