Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1971)

Unified Diff: Source/web/WebBindings.cpp

Issue 667583003: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/custom/V8WindowCustom.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebBindings.cpp
diff --git a/Source/web/WebBindings.cpp b/Source/web/WebBindings.cpp
index 2c9158fc408358fb4545441766ce477235c98eeb..e65c3234b467423be3905dd6fac26e81ff86c864 100644
--- a/Source/web/WebBindings.cpp
+++ b/Source/web/WebBindings.cpp
@@ -323,7 +323,7 @@ static NPObject* makeIntArrayImpl(const WebVector<int>& data, v8::Isolate* isola
result->Set(i, v8::Number::New(isolate, data[i]));
LocalDOMWindow* window = currentDOMWindow(isolate);
- return npCreateV8ScriptObject(0, result, window, isolate);
+ return npCreateV8ScriptObject(isolate, 0, result, window);
}
static NPObject* makeStringArrayImpl(const WebVector<WebString>& data, v8::Isolate* isolate)
@@ -334,7 +334,7 @@ static NPObject* makeStringArrayImpl(const WebVector<WebString>& data, v8::Isola
result->Set(i, v8String(isolate, data[i]));
LocalDOMWindow* window = currentDOMWindow(isolate);
- return npCreateV8ScriptObject(0, result, window, isolate);
+ return npCreateV8ScriptObject(isolate, 0, result, window);
}
bool WebBindings::getRange(NPObject* range, WebRange* webRange)
« no previous file with comments | « Source/bindings/core/v8/custom/V8WindowCustom.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698