Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 666693012: GP Emit Code takes a struct (Closed)

Created:
6 years, 2 months ago by joshua.litt
Modified:
6 years, 2 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -281 lines) Patch
M src/gpu/GrAAConvexPathRenderer.cpp View 2 chunks +7 lines, -13 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 4 chunks +15 lines, -27 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 6 chunks +23 lines, -42 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 9 chunks +25 lines, -62 lines 0 comments Download
M src/gpu/effects/GrCustomCoordsTextureEffect.cpp View 1 chunk +8 lines, -14 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 6 chunks +25 lines, -49 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 10 chunks +44 lines, -62 lines 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.h View 1 chunk +16 lines, -7 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
joshualitt
mostly just a retype
6 years, 2 months ago (2014-10-22 13:33:04 UTC) #2
bsalomon
lgtm
6 years, 2 months ago (2014-10-22 17:44:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666693012/1
6 years, 2 months ago (2014-10-22 17:47:59 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 17:56:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as c369e7c9992a86151a3ea0516ce5308c211b196b

Powered by Google App Engine
This is Rietveld 408576698