Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 666483002: Create snapshot/mac and move some files from snapshot and util to there (Closed)

Created:
6 years, 2 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad/+/master
Project:
crashpad
Visibility:
Public.

Description

Create snapshot/mac and move some files from snapshot and util to there. TEST=snapshot_test, util_test CheckedMachAddressRange.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/bcae4d94d58cd730b4045b3514a0ed0345245537

Patch Set 1 : Move mac files in snapshot to snapshot/mac #

Patch Set 2 : CheckedMachAddressRange: drop dependency on ProcessReader #

Patch Set 3 : Move process_reader, process_types, and mach_o_image*_reader from util/mac to snapshot/mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -8146 lines) Patch
D snapshot/cpu_context_mac.h View 1 chunk +0 lines, -115 lines 0 comments Download
D snapshot/cpu_context_mac.cc View 1 chunk +0 lines, -440 lines 0 comments Download
D snapshot/cpu_context_mac_test.cc View 1 chunk +0 lines, -421 lines 0 comments Download
D snapshot/exception_snapshot_mac.h View 1 chunk +0 lines, -91 lines 0 comments Download
D snapshot/exception_snapshot_mac.cc View 1 chunk +0 lines, -175 lines 0 comments Download
A + snapshot/mac/cpu_context_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + snapshot/mac/cpu_context_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
A + snapshot/mac/cpu_context_mac_test.cc View 1 chunk +1 line, -1 line 0 comments Download
A + snapshot/mac/exception_snapshot_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + snapshot/mac/exception_snapshot_mac.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A + snapshot/mac/mach_o_image_reader.h View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
A + snapshot/mac/mach_o_image_reader.cc View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
A + snapshot/mac/mach_o_image_reader_test.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + snapshot/mac/mach_o_image_segment_reader.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
A + snapshot/mac/mach_o_image_segment_reader.cc View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
A + snapshot/mac/mach_o_image_segment_reader_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + snapshot/mac/mach_o_image_symbol_table_reader.h View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
A + snapshot/mac/mach_o_image_symbol_table_reader.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
A + snapshot/mac/memory_snapshot_mac.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + snapshot/mac/memory_snapshot_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
A + snapshot/mac/process_reader.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + snapshot/mac/process_reader.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + snapshot/mac/process_reader_test.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + snapshot/mac/process_types.h View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
A + snapshot/mac/process_types.cc View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
A + snapshot/mac/process_types/all.proctype View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
A + snapshot/mac/process_types/crashreporterclient.proctype View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + snapshot/mac/process_types/custom.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + snapshot/mac/process_types/dyld_images.proctype View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + snapshot/mac/process_types/flavors.h View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
A + snapshot/mac/process_types/internal.h View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
A + snapshot/mac/process_types/loader.proctype View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + snapshot/mac/process_types/nlist.proctype View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + snapshot/mac/process_types/traits.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + snapshot/mac/process_types_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + snapshot/mac/system_snapshot_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + snapshot/mac/system_snapshot_mac.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + snapshot/mac/system_snapshot_mac_test.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + snapshot/mac/thread_snapshot_mac.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
A + snapshot/mac/thread_snapshot_mac.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
D snapshot/memory_snapshot_mac.h View 1 chunk +0 lines, -68 lines 0 comments Download
D snapshot/memory_snapshot_mac.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M snapshot/snapshot.gyp View 1 2 2 chunks +35 lines, -12 lines 0 comments Download
D snapshot/system_snapshot_mac.h View 1 chunk +0 lines, -101 lines 0 comments Download
D snapshot/system_snapshot_mac.cc View 1 chunk +0 lines, -399 lines 0 comments Download
D snapshot/system_snapshot_mac_test.cc View 1 chunk +0 lines, -176 lines 0 comments Download
D snapshot/thread_snapshot_mac.h View 1 chunk +0 lines, -85 lines 0 comments Download
D snapshot/thread_snapshot_mac.cc View 1 chunk +0 lines, -115 lines 0 comments Download
M util/mac/checked_mach_address_range.h View 1 3 chunks +8 lines, -11 lines 0 comments Download
M util/mac/checked_mach_address_range.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
M util/mac/checked_mach_address_range_test.cc View 1 2 6 chunks +84 lines, -86 lines 0 comments Download
D util/mac/mach_o_image_reader.h View 1 2 1 chunk +0 lines, -343 lines 0 comments Download
M util/mac/mach_o_image_reader.cc View 1 2 1 chunk +0 lines, -671 lines 0 comments Download
D util/mac/mach_o_image_reader_test.cc View 1 2 1 chunk +0 lines, -640 lines 0 comments Download
D util/mac/mach_o_image_segment_reader.h View 1 2 1 chunk +0 lines, -255 lines 0 comments Download
M util/mac/mach_o_image_segment_reader.cc View 1 2 1 chunk +0 lines, -275 lines 0 comments Download
D util/mac/mach_o_image_segment_reader_test.cc View 1 2 1 chunk +0 lines, -188 lines 0 comments Download
D util/mac/mach_o_image_symbol_table_reader.h View 1 2 1 chunk +0 lines, -135 lines 0 comments Download
M util/mac/mach_o_image_symbol_table_reader.cc View 1 2 1 chunk +0 lines, -274 lines 0 comments Download
D util/mac/process_reader.h View 1 2 1 chunk +0 lines, -229 lines 0 comments Download
D util/mac/process_reader.cc View 1 2 1 chunk +0 lines, -716 lines 0 comments Download
D util/mac/process_reader_test.cc View 1 2 1 chunk +0 lines, -692 lines 0 comments Download
D util/mac/process_types.h View 1 2 1 chunk +0 lines, -183 lines 0 comments Download
D util/mac/process_types.cc View 1 2 1 chunk +0 lines, -244 lines 0 comments Download
D util/mac/process_types/all.proctype View 1 2 1 chunk +0 lines, -25 lines 0 comments Download
D util/mac/process_types/crashreporterclient.proctype View 1 2 1 chunk +0 lines, -40 lines 0 comments Download
D util/mac/process_types/custom.cc View 1 2 1 chunk +0 lines, -95 lines 0 comments Download
D util/mac/process_types/dyld_images.proctype View 1 2 1 chunk +0 lines, -103 lines 0 comments Download
D util/mac/process_types/flavors.h View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
D util/mac/process_types/internal.h View 1 2 1 chunk +0 lines, -36 lines 0 comments Download
D util/mac/process_types/loader.proctype View 1 2 1 chunk +0 lines, -140 lines 0 comments Download
D util/mac/process_types/nlist.proctype View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
D util/mac/process_types/traits.h View 1 2 1 chunk +0 lines, -42 lines 0 comments Download
D util/mac/process_types_test.cc View 1 2 1 chunk +0 lines, -263 lines 0 comments Download
M util/util.gyp View 1 2 2 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
Mark Mentovai
6 years, 2 months ago (2014-10-17 15:56:41 UTC) #6
Robert Sesek
LGTM
6 years, 2 months ago (2014-10-17 17:05:43 UTC) #7
Mark Mentovai
6 years, 2 months ago (2014-10-17 17:41:51 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:90001) manually as
bcae4d94d58cd730b4045b3514a0ed0345245537 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698