snapshot/mac/process_types/dyld_images.proctype - Issue 666483002: Create snapshot/mac and move some files from snapshot and util to there

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/mac/process_types/dyld_images.proctype

Issue 666483002: Create snapshot/mac and move some files from snapshot and util to there (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad/+/master

Patch Set: Move process_reader, process_types, and mach_o_image*_reader from util/mac to snapshot/mac Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: snapshot/mac/process_types/dyld_images.proctype

diff --git a/util/mac/process_types/dyld_images.proctype b/snapshot/mac/process_types/dyld_images.proctype

similarity index 92%

rename from util/mac/process_types/dyld_images.proctype

rename to snapshot/mac/process_types/dyld_images.proctype

index 643f54c0cc244671e666b18a966211193ea1c5a4..de59a86c8ef78209c2c37a6d02306a185fadd6f9 100644

--- a/util/mac/process_types/dyld_images.proctype

+++ b/snapshot/mac/process_types/dyld_images.proctype

@@ -17,8 +17,8 @@

// This file is intended to be included multiple times in the same translation

// unit, so #include guards are intentionally absent.

-// This file is included by util/mac/process_types.h and

-// util/mac/process_types.cc to produce process type struct definitions and

+// This file is included by snapshot/mac/process_types.h and

+// snapshot/mac/process_types.cc to produce process type struct definitions and

// accessors.

PROCESS_TYPE_STRUCT_BEGIN(dyld_image_info)

@@ -35,8 +35,8 @@ PROCESS_TYPE_STRUCT_END(dyld_uuid_info)

// dyld_all_image_infos is variable-length. Its length dictated by its |version|

// field which is always present. A custom implementation of the flavored

// ReadSpecificInto function that understands how to map this field to the

-// structure’s actual size is provided in util/mac/process_types/custom.cc. No

-// implementation of ReadArrayInto is provided because dyld_all_image_infos

+// structure’s actual size is provided in snapshot/mac/process_types/custom.cc.

+// No implementation of ReadArrayInto is provided because dyld_all_image_infos

// structs are singletons in a process and are never present in arrays, so the

// functionality is unnecessary.

« no previous file with comments | « snapshot/mac/process_types/custom.cc ('k') | snapshot/mac/process_types/flavors.h » ('j') | no next file with comments »