Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: snapshot/mac/mach_o_image_symbol_table_reader.cc

Issue 666483002: Create snapshot/mac and move some files from snapshot and util to there (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad/+/master
Patch Set: Move process_reader, process_types, and mach_o_image*_reader from util/mac to snapshot/mac Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/mac/mach_o_image_symbol_table_reader.h ('k') | snapshot/mac/memory_snapshot_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/mac/mach_o_image_symbol_table_reader.cc
diff --git a/util/mac/mach_o_image_symbol_table_reader.cc b/snapshot/mac/mach_o_image_symbol_table_reader.cc
similarity index 97%
rename from util/mac/mach_o_image_symbol_table_reader.cc
rename to snapshot/mac/mach_o_image_symbol_table_reader.cc
index 8db0109c541a16c7031d11d1dbc9ffb2a20d5f9e..ff264471199c69e72d4b97862b5e6144ffe4be70 100644
--- a/util/mac/mach_o_image_symbol_table_reader.cc
+++ b/snapshot/mac/mach_o_image_symbol_table_reader.cc
@@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-#include "util/mac/mach_o_image_symbol_table_reader.h"
+#include "snapshot/mac/mach_o_image_symbol_table_reader.h"
#include <mach-o/loader.h>
#include <mach-o/nlist.h>
@@ -43,8 +43,9 @@ class MachOImageSymbolTableReaderInitializer {
linkedit_range_(),
process_reader_(process_reader),
linkedit_segment_(linkedit_segment) {
- linkedit_range_.SetRange(
- process_reader_, linkedit_segment->Address(), linkedit_segment->Size());
+ linkedit_range_.SetRange(process_reader_->Is64Bit(),
+ linkedit_segment->Address(),
+ linkedit_segment->Size());
DCHECK(linkedit_range_.IsValid());
}
@@ -198,7 +199,7 @@ class MachOImageSymbolTableReaderInitializer {
bool IsInLinkEditSegment(mach_vm_address_t address,
mach_vm_size_t size,
const char* tag) const {
- CheckedMachAddressRange subrange(process_reader_, address, size);
+ CheckedMachAddressRange subrange(process_reader_->Is64Bit(), address, size);
if (!subrange.IsValid()) {
LOG(WARNING) << base::StringPrintf("invalid %s range (0x%llx + 0x%llx)",
tag,
« no previous file with comments | « snapshot/mac/mach_o_image_symbol_table_reader.h ('k') | snapshot/mac/memory_snapshot_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698