[ServiceWorker] Handle ServiceWorker script fetch error code correctly. [chromium]

[ServiceWorker] Handle ServiceWorker script fetch error code correctly. [chromium]

LayoutTest is here: https://codereview.chromium.org/663723002

BUG=424464
TEST=http/tests/serviceworker/registration.html

Committed: https://crrev.com/620392a87b1e0a7833eb88012fe1f891e3087876
Cr-Commit-Position: refs/heads/master@{#300079}

[horo, 2014-10-17 06:02:22]

horo@chromium.org changed reviewers:
+ falken@chromium.org

[horo, 2014-10-17 06:02:23]

falken@
Could you please review this?

[falken, 2014-10-17 06:34:44]

https://codereview.chromium.org/660973002/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_register_job.cc (right):

https://codereview.chromium.org/660973002/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_register_job.cc:356: status =
SERVICE_WORKER_ERROR_NETWORK;
Can you help me understand what's going on here? What was error() returning that
caused NOTREACHED(), and why isn't that a bug?

[horo, 2014-10-17 07:15:51]

https://codereview.chromium.org/660973002/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_register_job.cc (right):

https://codereview.chromium.org/660973002/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_register_job.cc:356: status =
SERVICE_WORKER_ERROR_NETWORK;
On 2014/10/17 06:34:44, falken wrote:
> Can you help me understand what's going on here? What was error() returning
that
> caused NOTREACHED(), and why isn't that a bug?

main_script_status is set by NotifyFinishedCaching() called from
ServiceWorkerWriteToCacheJob.
But main_script_status.error could be the other value because it is passed from
URLRequest.
This could be many other error codes.
For example invalid-chunked-encoding-with-flush.php in
https://codereview.chromium.org/660973002 will cause INVALID_CHUNKED_ENCODING
error.

[falken, 2014-10-17 07:23:17]

lgtm

https://codereview.chromium.org/660973002/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_register_job.cc (right):

https://codereview.chromium.org/660973002/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_register_job.cc:356: status =
SERVICE_WORKER_ERROR_NETWORK;
On 2014/10/17 07:15:51, horo wrote:
> On 2014/10/17 06:34:44, falken wrote:
> > Can you help me understand what's going on here? What was error() returning
> that
> > caused NOTREACHED(), and why isn't that a bug?
> 
> main_script_status is set by NotifyFinishedCaching() called from
> ServiceWorkerWriteToCacheJob.
> But main_script_status.error could be the other value because it is passed
from
> URLRequest.
> This could be many other error codes.
> For example invalid-chunked-encoding-with-flush.php in
> https://codereview.chromium.org/660973002 will cause INVALID_CHUNKED_ENCODING
> error.

OK I see.

[horo, 2014-10-17 07:37:04]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2014-10-17 07:37:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/660973002/1

[commit-bot: I haz the power, 2014-10-17 08:23:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-10-17 08:23:56]

Patchset 1 (id:??) landed as
https://crrev.com/620392a87b1e0a7833eb88012fe1f891e3087876
Cr-Commit-Position: refs/heads/master@{#300079}