[ServiceWorker] Handle ServiceWorker script fetch error code correctly. [chromium]

content/browser/service_worker/service_worker_register_job.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/service_worker_register_job.h"
 
 #include <vector>
 
 #include "base/message_loop/message_loop.h"
 #include "content/browser/service_worker/service_worker_context_core.h"
@@ skipping 334 matching lines @@
       new_version()->script_cache_map()->main_script_status();
   if (main_script_status.status() != net::URLRequestStatus::SUCCESS) {
     switch (main_script_status.error()) {
       case net::ERR_INSECURE_RESPONSE:
       case net::ERR_UNSAFE_REDIRECT:
         status = SERVICE_WORKER_ERROR_SECURITY;
         break;
       case net::ERR_ABORTED:
         status = SERVICE_WORKER_ERROR_ABORT;
         break;
-      case net::ERR_FAILED:
+      default:
         status = SERVICE_WORKER_ERROR_NETWORK;

[falken, 2014/10/17 06:34:44]

Can you help me understand what's going on here? What was error() returning that
caused NOTREACHED(), and why isn't that a bug?

[horo, 2014/10/17 07:15:51]

main_script_status is set by NotifyFinishedCaching() called from
ServiceWorkerWriteToCacheJob.
But main_script_status.error could be the other value because it is passed from
URLRequest.
This could be many other error codes.
For example invalid-chunked-encoding-with-flush.php in
https://codereview.chromium.org/660973002 will cause INVALID_CHUNKED_ENCODING
error.

[falken, 2014/10/17 07:23:17]

OK I see.

-        break;
-      default:
-        NOTREACHED();
     }
   }
   Complete(status);
 }
 
 // This function corresponds to the spec's [[Install]] algorithm.
 void ServiceWorkerRegisterJob::InstallAndContinue() {
   SetPhase(INSTALL);
 
   // "2. Set registration.installingWorker to worker."
@@ skipping 184 matching lines @@
     ServiceWorkerProviderHost* host = it->GetProviderHost();
     if (ServiceWorkerUtils::ScopeMatches(registration->pattern(),
                                          host->document_url())) {
       if (host->CanAssociateRegistration(registration))
         host->AssociateRegistration(registration);
     }
   }
 }
 
 }  // namespace content