Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 663723002: [ServiceWorker] Handle ServiceWorker script fetch error code correctly. [blink] (Closed)

Created:
6 years, 2 months ago by horo
Modified:
6 years, 2 months ago
Reviewers:
falken
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, xiang
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Handle ServiceWorker script fetch error code correctly. [blink] Chromium side fix is here: https://codereview.chromium.org/660973002 BUG=424464 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183878

Patch Set 1 : #

Patch Set 2 : use promise_test and assert_promise_rejects #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -106 lines) Patch
M LayoutTests/http/tests/serviceworker/registration.html View 1 1 chunk +65 lines, -106 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/resources/invalid-chunked-encoding.php View 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/resources/invalid-chunked-encoding-with-flush.php View 1 chunk +7 lines, -0 lines 2 comments Download

Messages

Total messages: 10 (3 generated)
horo
falken@ Could you please review this?
6 years, 2 months ago (2014-10-17 06:02:36 UTC) #3
falken
https://codereview.chromium.org/663723002/diff/40001/LayoutTests/http/tests/serviceworker/resources/invalid-chunked-encoding-with-flush.php File LayoutTests/http/tests/serviceworker/resources/invalid-chunked-encoding-with-flush.php (right): https://codereview.chromium.org/663723002/diff/40001/LayoutTests/http/tests/serviceworker/resources/invalid-chunked-encoding-with-flush.php#newcode5 LayoutTests/http/tests/serviceworker/resources/invalid-chunked-encoding-with-flush.php:5: sleep(1); why is this sleep needed? does it block ...
6 years, 2 months ago (2014-10-17 06:39:17 UTC) #4
horo
https://codereview.chromium.org/663723002/diff/40001/LayoutTests/http/tests/serviceworker/resources/invalid-chunked-encoding-with-flush.php File LayoutTests/http/tests/serviceworker/resources/invalid-chunked-encoding-with-flush.php (right): https://codereview.chromium.org/663723002/diff/40001/LayoutTests/http/tests/serviceworker/resources/invalid-chunked-encoding-with-flush.php#newcode5 LayoutTests/http/tests/serviceworker/resources/invalid-chunked-encoding-with-flush.php:5: sleep(1); On 2014/10/17 06:39:17, falken wrote: > why is ...
6 years, 2 months ago (2014-10-17 06:53:22 UTC) #5
falken
lgtm
6 years, 2 months ago (2014-10-17 07:23:46 UTC) #6
falken
lgtm
6 years, 2 months ago (2014-10-17 07:23:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663723002/40001
6 years, 2 months ago (2014-10-17 09:15:25 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 10:53:52 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as 183878

Powered by Google App Engine
This is Rietveld 408576698