[ServiceWorker] Handle ServiceWorker script fetch error code correctly. [chromium]

content/browser/service_worker/service_worker_register_job.cc

Index: content/browser/service_worker/service_worker_register_job.cc
diff --git a/content/browser/service_worker/service_worker_register_job.cc b/content/browser/service_worker/service_worker_register_job.cc
index 650e00e70ead4010aa7493c89cb12312af4f7691..7921ee437b0a06d4e5cc66b99791ec48dcc15c54 100644
--- a/content/browser/service_worker/service_worker_register_job.cc
+++ b/content/browser/service_worker/service_worker_register_job.cc
@@ -352,11 +352,8 @@ void ServiceWorkerRegisterJob::OnStartWorkerFinished(
       case net::ERR_ABORTED:
         status = SERVICE_WORKER_ERROR_ABORT;
         break;
-      case net::ERR_FAILED:
-        status = SERVICE_WORKER_ERROR_NETWORK;
-        break;
       default:
-        NOTREACHED();
+        status = SERVICE_WORKER_ERROR_NETWORK;

[falken, 2014/10/17 06:34:44]

Can you help me understand what's going on here? What was error() returning that
caused NOTREACHED(), and why isn't that a bug?

[horo, 2014/10/17 07:15:51]

main_script_status is set by NotifyFinishedCaching() called from
ServiceWorkerWriteToCacheJob.
But main_script_status.error could be the other value because it is passed from
URLRequest.
This could be many other error codes.
For example invalid-chunked-encoding-with-flush.php in
https://codereview.chromium.org/660973002 will cause INVALID_CHUNKED_ENCODING
error.

[falken, 2014/10/17 07:23:17]

OK I see.

     }
   }
   Complete(status);