Fix suspicious code detected by closure compiler.

Fix suspicious code detected by closure compiler.

BUG=406995
TBR=benwells@chromium.org
TEST=run browser_test --gtest_filter=*FileManager*

Committed: https://crrev.com/e89e058e30e09e1b67be326e8e966ceadc09d08f
Cr-Commit-Position: refs/heads/master@{#300419}

[fukino, 2014-10-17 08:09:41]

fukino@chromium.org changed reviewers:
+ hirono@chromium.org

[fukino, 2014-10-17 08:10:00]

hirono@, could you take a look? Thanks!

[hirono, 2014-10-17 08:32:09]

https://codereview.chromium.org/657253004/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/background/js/drive_sync_handler.js (right):

https://codereview.chromium.org/657253004/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/background/js/drive_sync_handler.js:157:
chrome.fileManagerPrivate.cancelFileTransfers();
CancelFileTransfersCallback is optional?
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/exte...

https://codereview.chromium.org/657253004/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/common/js/util.js (right):

https://codereview.chromium.org/657253004/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/common/js/util.js:463: keys.sort(function(a, b) {
return map[a].expire - map[b].expire; });
expire is string? we cannot use '-' for strings.

https://codereview.chromium.org/657253004/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/file_tasks.js (right):

https://codereview.chromium.org/657253004/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/file_tasks.js:378: var onViewFiles =
function(result) {
We can remove the function?

https://codereview.chromium.org/657253004/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/ui/directory_tree.js (right):

https://codereview.chromium.org/657253004/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:527:
entries.sort(function(a, b) { return b.toURL() - a.toURL(); });
We cannot use '-' for strings.

[fukino, 2014-10-17 10:03:50]

Thanks!!

https://codereview.chromium.org/657253004/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/background/js/drive_sync_handler.js (right):

https://codereview.chromium.org/657253004/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/background/js/drive_sync_handler.js:157:
chrome.fileManagerPrivate.cancelFileTransfers();
On 2014/10/17 08:32:08, hirono wrote:
> CancelFileTransfersCallback is optional?
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/exte...

Edited idl file to make the callback optional.

https://codereview.chromium.org/657253004/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/common/js/util.js (right):

https://codereview.chromium.org/657253004/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/common/js/util.js:463: keys.sort(function(a, b) {
return map[a].expire - map[b].expire; });
On 2014/10/17 08:32:08, hirono wrote:
> expire is string? we cannot use '-' for strings.

I think they are number.
https://code.google.com/p/chromium/codesearch#chromium/src/ui/file_manager/fi...

https://codereview.chromium.org/657253004/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/file_tasks.js (right):

https://codereview.chromium.org/657253004/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/file_tasks.js:378: var onViewFiles =
function(result) {
On 2014/10/17 08:32:09, hirono wrote:
> We can remove the function?

This function is in use.

https://codereview.chromium.org/657253004/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/ui/directory_tree.js (right):

https://codereview.chromium.org/657253004/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:527:
entries.sort(function(a, b) { return b.toURL() - a.toURL(); });
On 2014/10/17 08:32:09, hirono wrote:
> We cannot use '-' for strings.

Oops! Thank you for pointing this out!
Done.

[hirono, 2014-10-17 10:16:56]

lgtm!

https://codereview.chromium.org/657253004/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/common/js/util.js (right):

https://codereview.chromium.org/657253004/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/common/js/util.js:463: keys.sort(function(a, b) {
return map[a].expire - map[b].expire; });
On 2014/10/17 10:03:50, fukino wrote:
> On 2014/10/17 08:32:08, hirono wrote:
> > expire is string? we cannot use '-' for strings.
> 
> I think they are number.
>
https://code.google.com/p/chromium/codesearch#chromium/src/ui/file_manager/fi...

Thanks!

[fukino, 2014-10-17 10:23:55]

fukino@chromium.org changed reviewers:
+ benwells@chromium.org

[fukino, 2014-10-17 10:25:02]

benwells@, could you take a look at
chrome/common/extensions/api/file_manager_private.idl?
I made the callback optional as the preceding parameter is optional.

[fukino, 2014-10-21 01:18:11]

TBRed benwells for simple modification on file_manager_private.idl (made one
parameter optional)

[fukino, 2014-10-21 01:18:53]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2014-10-21 01:19:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/657253004/20001

[commit-bot: I haz the power, 2014-10-21 03:20:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-21 03:20:38]

Exceeded time limit waiting for builds to trigger.

[fukino, 2014-10-21 03:21:45]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2014-10-21 03:22:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/657253004/20001

[benwells, 2014-10-21 03:53:27]

lgtm. In future please ping or find another reviewer instead of tbr'ing. Changes
being simple isn't a valid reason to tbr.

[commit-bot: I haz the power, 2014-10-21 04:15:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-21 04:17:24]

Patchset 2 (id:??) landed as
https://crrev.com/e89e058e30e09e1b67be326e8e966ceadc09d08f
Cr-Commit-Position: refs/heads/master@{#300419}

[fukino, 2014-10-21 04:23:53]

On 2014/10/21 03:53:27, benwells wrote:
> lgtm. In future please ping or find another reviewer instead of tbr'ing.
Changes
> being simple isn't a valid reason to tbr.

Thank you Ben! I misunderstood TBR. I'll use it in right way from next time.