ui/file_manager/file_manager/foreground/js/file_tasks.js - Issue 657253004: Fix suspicious code detected by closure compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/file_tasks.js

Issue 657253004: Fix suspicious code detected by closure compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reflect review comments. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/file_manager/file_manager/foreground/js/file_tasks.js

diff --git a/ui/file_manager/file_manager/foreground/js/file_tasks.js b/ui/file_manager/file_manager/foreground/js/file_tasks.js

index 3f7c5da8a7eaacfdee437c6902d48a1a486a8943..fcf383a4bb872c39245b0ca806621602bfae2b86 100644

--- a/ui/file_manager/file_manager/foreground/js/file_tasks.js

+++ b/ui/file_manager/file_manager/foreground/js/file_tasks.js

@@ -378,7 +378,7 @@ FileTasks.prototype.executeDefaultInternal_ = function(entries, opt_callback) {

var onViewFiles = function(result) {

switch (result) {

case 'opened':

- callback(success, entries);

+ callback(true, entries);

break;

case 'message_sent':

util.isTeleported(window).then(function(teleported) {

@@ -387,10 +387,10 @@ FileTasks.prototype.executeDefaultInternal_ = function(entries, opt_callback) {

this.fileManager_.ui.alertDialog, entries);

}

}.bind(this));

- callback(success, entries);

+ callback(true, entries);

break;

case 'empty':

- callback(success, entries);

+ callback(true, entries);

break;

case 'failed':

onViewFilesFailure();