Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: ui/file_manager/file_manager/foreground/js/metadata/byte_reader.js

Issue 657253004: Fix suspicious code detected by closure compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reflect review comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/metadata/byte_reader.js
diff --git a/ui/file_manager/file_manager/foreground/js/metadata/byte_reader.js b/ui/file_manager/file_manager/foreground/js/metadata/byte_reader.js
index e3fbfb210e9c875f7f49617db0a5c51fb1f6b952..e422bf5077e735b4ed97c32515114c27b6ee0115 100644
--- a/ui/file_manager/file_manager/foreground/js/metadata/byte_reader.js
+++ b/ui/file_manager/file_manager/foreground/js/metadata/byte_reader.js
@@ -305,7 +305,7 @@ ByteReader.prototype.validateRead = function(size, opt_end) {
if (typeof opt_end == 'undefined')
opt_end = this.view_.byteLength;
- ByteReader.validateRead(this.view_, this.pos_, size, opt_end);
+ ByteReader.validateRead(this.pos_, size, opt_end);
};
/**
@@ -439,7 +439,7 @@ ByteReader.prototype.readSlice = function(size, opt_end,
var arrayConstructor = opt_arrayConstructor || Uint8Array;
var slice = new arrayConstructor(
- this.view_.buffer, this.view_.byteOffset + this.pos, size);
+ this.view_.buffer, this.view_.byteOffset + this.pos_, size);
this.pos_ += size;
return slice;

Powered by Google App Engine
This is Rietveld 408576698