Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1990)

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js

Issue 657253004: Fix suspicious code detected by closure compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reflect review comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/file_manager/file_manager/foreground/js/ui/file_table.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js
diff --git a/ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js b/ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js
index 6f1da8cdfcb1f1496d93a51a0906bb247e1b0a69..fc42c1c86c0e50e069166b26a494681a4500dd7f 100644
--- a/ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js
+++ b/ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js
@@ -257,7 +257,7 @@ SuggestAppsDialog.prototype.showInternal_ =
if (!show) {
console.error('SuggestAppsDialog can\'t be shown');
this.state_ = SuggestAppsDialog.State.UNINITIALIZED;
- this.onHide();
+ this.onHide_();
return;
}
@@ -331,7 +331,7 @@ SuggestAppsDialog.prototype.onWidgetLoaded_ = function(event) {
* @private
*/
SuggestAppsDialog.prototype.onWidgetLoadFailed_ = function(event) {
- SuggestAppsDialog.Metrics.recordLoad(SuggestAppsDialog.Metrics.LOAD.FAILURE);
+ SuggestAppsDialog.Metrics.recordLoad(SuggestAppsDialog.Metrics.LOAD.FAILED);
this.frame_.classList.remove('show-spinner');
this.state_ = SuggestAppsDialog.State.INITIALIZE_FAILED_CLOSING;
@@ -388,7 +388,7 @@ SuggestAppsDialog.prototype.onInstallCompleted_ = function(result, error) {
switch (result) {
case AppInstaller.Result.SUCCESS:
SuggestAppsDialog.Metrics.recordInstall(
- SuggestAppsDialog.Metrics.INSTALL.SUCCESS);
+ SuggestAppsDialog.Metrics.INSTALL.SUCCEEDED);
this.hide();
break;
case AppInstaller.Result.CANCELLED:
@@ -477,12 +477,12 @@ SuggestAppsDialog.prototype.onHide_ = function(opt_originalOnHide) {
case SuggestAppsDialog.State.CANCELED_CLOSING:
result = SuggestAppsDialog.Result.USER_CANCELL;
SuggestAppsDialog.Metrics.recordCloseDialog(
- SuggestAppsDialog.Metrics.CLOSE_DIALOG.USER_CANCELL);
+ SuggestAppsDialog.Metrics.CLOSE_DIALOG.USER_CANCELLED);
break;
case SuggestAppsDialog.State.OPENING_WEBSTORE_CLOSING:
result = SuggestAppsDialog.Result.WEBSTORE_LINK_OPENED;
SuggestAppsDialog.Metrics.recordCloseDialog(
- SuggestAppsDialog.Metrics.CLOSE_DIALOG.WEB_STORE_LINK);
+ SuggestAppsDialog.Metrics.CLOSE_DIALOG.WEBSTORE_LINK_OPENED);
break;
default:
result = SuggestAppsDialog.Result.USER_CANCELL;
@@ -515,7 +515,7 @@ SuggestAppsDialog.Metrics.LOAD = {
* @const
*/
SuggestAppsDialog.Metrics.CLOSE_DIALOG = {
- UNKOWN_ERROR: 0,
+ UNKNOWN_ERROR: 0,
ITEM_INSTALLED: 1,
USER_CANCELLED: 2,
WEBSTORE_LINK_OPENED: 3,
« no previous file with comments | « ui/file_manager/file_manager/foreground/js/ui/file_table.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698