Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/file_grid.js

Issue 657253004: Fix suspicious code detected by closure compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reflect review comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/ui/file_grid.js
diff --git a/ui/file_manager/file_manager/foreground/js/ui/file_grid.js b/ui/file_manager/file_manager/foreground/js/ui/file_grid.js
index d1398d93d5e58208294dd7501fd42402d0cb282f..005a54b994d9b48b7414e7de364cea3b4e4d86b1 100644
--- a/ui/file_manager/file_manager/foreground/js/ui/file_grid.js
+++ b/ui/file_manager/file_manager/foreground/js/ui/file_grid.js
@@ -230,7 +230,7 @@ FileGrid.Item.decorate = function(li, entry, grid) {
// TODO(mtomasz): Pass the metadata cache and the volume manager directly
// instead of accessing private members of grid.
FileGrid.decorateThumbnail(
- li, entry, grid.metadataCache_, grid.volumeManager_, true);
+ li, entry, grid.metadataCache_, grid.volumeManager_);
// Override the default role 'listitem' to 'option' to match the parent's
// role (listbox).
@@ -297,7 +297,7 @@ FileGrid.prototype.getHitElements = function(x, y, opt_width, opt_height) {
var horizontalEndIndex = Math.min(this.columns, this.getHitIndex_(
right, itemMetrics.width, itemMetrics.marginLeft));
var verticalStartIndex = this.getHitIndex_(
- y, itemMetrics.height, itemMetrics.height - itemMetrics.bottom);
+ y, itemMetrics.height, itemMetrics.height - itemMetrics.marginBottom);
var verticalEndIndex = this.getHitIndex_(
bottom, itemMetrics.height, itemMetrics.marginTop);
for (var verticalIndex = verticalStartIndex;

Powered by Google App Engine
This is Rietveld 408576698