Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 654263004: Simplify ScopedVector<scoped_ptr<T>> to ScopedVector<T>. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Simplify ScopedVector<scoped_ptr<T>> to ScopedVector<T>. Also removes a couple more PassAs() calls. BUG=423621 Committed: https://crrev.com/048019f3581cdd2292e847732ea778dbb78cdc8d Cr-Commit-Position: refs/heads/master@{#300129}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M tools/gn/function_get_target_outputs.cc View 1 chunk +1 line, -2 lines 0 comments Download
M tools/gn/function_get_target_outputs_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/gn/function_toolchain.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/functions.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/loader.cc View 1 chunk +4 lines, -2 lines 1 comment Download
M tools/gn/scope.h View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/gn/target_generator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
https://codereview.chromium.org/654263004/diff/1/tools/gn/loader.cc File tools/gn/loader.cc (right): https://codereview.chromium.org/654263004/diff/1/tools/gn/loader.cc#newcode269 tools/gn/loader.cc:269: settings->build_settings()->ItemDefined(make_scoped_ptr(item)); This is a bit awkward, but I don't ...
6 years, 2 months ago (2014-10-15 20:26:09 UTC) #2
brettw
lgtm
6 years, 2 months ago (2014-10-17 17:32:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654263004/1
6 years, 2 months ago (2014-10-17 17:34:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 18:03:37 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 18:04:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/048019f3581cdd2292e847732ea778dbb78cdc8d
Cr-Commit-Position: refs/heads/master@{#300129}

Powered by Google App Engine
This is Rietveld 408576698