Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools/gn/loader.cc

Issue 654263004: Simplify ScopedVector<scoped_ptr<T>> to ScopedVector<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/functions.cc ('k') | tools/gn/scope.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/loader.cc
diff --git a/tools/gn/loader.cc b/tools/gn/loader.cc
index be5f5cc62ab4f0c46909c36bf48be9bffedf67fc..628a08e719745f63176c8030c2aa0257c5b0cd17 100644
--- a/tools/gn/loader.cc
+++ b/tools/gn/loader.cc
@@ -265,8 +265,10 @@ void LoaderImpl::BackgroundLoadFile(const Settings* settings,
g_scheduler->FailWithError(err);
// Pass all of the items that were defined off to the builder.
- for (const auto& item : collected_items)
- settings->build_settings()->ItemDefined(item->Pass());
+ for (auto& item : collected_items) {
+ settings->build_settings()->ItemDefined(make_scoped_ptr(item));
dcheng 2014/10/15 20:26:09 This is a bit awkward, but I don't know of a bette
+ item = nullptr;
+ }
trace.Done();
« no previous file with comments | « tools/gn/functions.cc ('k') | tools/gn/scope.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698