Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Unified Diff: tools/gn/function_toolchain.cc

Issue 654263004: Simplify ScopedVector<scoped_ptr<T>> to ScopedVector<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/function_toolchain.cc
diff --git a/tools/gn/function_toolchain.cc b/tools/gn/function_toolchain.cc
index 85163c173a5c0607ce44f2bb323e4e0b86402b85..34145f23508e904aa852802374a2de74674d2cc6 100644
--- a/tools/gn/function_toolchain.cc
+++ b/tools/gn/function_toolchain.cc
@@ -342,7 +342,7 @@ Value RunToolchain(Scope* scope,
*err = Err(function, "Can't define a toolchain in this context.");
return Value();
}
- collector->push_back(new scoped_ptr<Item>(toolchain.PassAs<Item>()));
+ collector->push_back(toolchain.release());
return Value();
}

Powered by Google App Engine
This is Rietveld 408576698