Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: tools/gn/target_generator.cc

Issue 654263004: Simplify ScopedVector<scoped_ptr<T>> to ScopedVector<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gn/loader.cc ('K') | « tools/gn/scope.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/target_generator.cc
diff --git a/tools/gn/target_generator.cc b/tools/gn/target_generator.cc
index 975ff722414da3881ae401c05028fce1db92fbc5..db7befcab947fb6e3758c6f9b9e97e8ba93c8db8 100644
--- a/tools/gn/target_generator.cc
+++ b/tools/gn/target_generator.cc
@@ -126,7 +126,7 @@ void TargetGenerator::GenerateTarget(Scope* scope,
*err = Err(function_call, "Can't define a target in this context.");
return;
}
- collector->push_back(new scoped_ptr<Item>(target.PassAs<Item>()));
+ collector->push_back(target.release());
}
const BuildSettings* TargetGenerator::GetBuildSettings() const {
« tools/gn/loader.cc ('K') | « tools/gn/scope.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698