Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: tools/gn/function_get_target_outputs_unittest.cc

Issue 654263004: Simplify ScopedVector<scoped_ptr<T>> to ScopedVector<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/function_get_target_outputs_unittest.cc
diff --git a/tools/gn/function_get_target_outputs_unittest.cc b/tools/gn/function_get_target_outputs_unittest.cc
index ab89343a22b12e4eca7891c453d814672fe34f55..be46380c39d91b3fb5a71c378b3728e372a1814d 100644
--- a/tools/gn/function_get_target_outputs_unittest.cc
+++ b/tools/gn/function_get_target_outputs_unittest.cc
@@ -65,7 +65,7 @@ TEST_F(GetTargetOutputsTest, Copy) {
action->action_values().outputs() =
SubstitutionList::MakeForTest("//out/Debug/{{source_file_part}}.one");
- items_.push_back(new scoped_ptr<Item>(action));
+ items_.push_back(action);
Err err;
Value result = GetTargetOutputs("//foo:bar", &err);
@@ -80,7 +80,7 @@ TEST_F(GetTargetOutputsTest, Action) {
"//output1.txt",
"//output2.txt");
- items_.push_back(new scoped_ptr<Item>(action));
+ items_.push_back(action);
Err err;
Value result = GetTargetOutputs("//foo:bar", &err);
@@ -96,7 +96,7 @@ TEST_F(GetTargetOutputsTest, ActionForeach) {
"//out/Debug/{{source_file_part}}.one",
"//out/Debug/{{source_file_part}}.two");
- items_.push_back(new scoped_ptr<Item>(action));
+ items_.push_back(action);
Err err;
Value result = GetTargetOutputs("//foo:bar", &err);

Powered by Google App Engine
This is Rietveld 408576698