|
Standardize usage of virtual/override/final in chrome/browser/signin/
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG= 417463
R=rogerta@chromium.org
Committed: https://crrev.com/6dddcd8e343a1bb8639cf45eac5827508c7a9afc
Cr-Commit-Position: refs/heads/master@{#300705}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+177 lines, -187 lines) |
Patch |
 |
M |
chrome/browser/signin/about_signin_internals_factory.h
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/account_reconcilor_factory.h
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/account_tracker_service_factory.h
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/chrome_signin_client.h
|
View
|
|
2 chunks |
+24 lines, -25 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/chrome_signin_client_factory.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/easy_unlock_screenlock_state_handler.h
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc
|
View
|
|
3 chunks |
+13 lines, -13 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/easy_unlock_service.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/easy_unlock_service.cc
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/easy_unlock_service_factory.h
|
View
|
|
1 chunk |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/easy_unlock_service_regular.h
|
View
|
|
1 chunk |
+18 lines, -18 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/easy_unlock_toggle_flow.h
|
View
|
|
1 chunk |
+10 lines, -12 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/easy_unlock_toggle_flow.cc
|
View
|
|
1 chunk |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/fake_account_reconcilor.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/fake_account_tracker_service.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/fake_profile_oauth2_token_service.h
|
View
|
|
2 chunks |
+19 lines, -20 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/fake_signin_manager.h
|
View
|
|
3 chunks |
+5 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/principals_message_filter.h
|
View
|
|
1 chunk |
+4 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/profile_identity_provider.h
|
View
|
|
1 chunk |
+10 lines, -10 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/profile_oauth2_token_service_factory.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/signin_browsertest.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/signin_global_error.h
|
View
|
|
2 chunks |
+15 lines, -15 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/signin_global_error_factory.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/signin_manager_factory.h
|
View
|
|
2 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/signin_manager_unittest.cc
|
View
|
|
2 chunks |
+7 lines, -9 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/signin_names_io_thread.h
|
View
|
|
2 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
Total messages: 14 (5 generated)
|